Hi Jason, I'm glad this was able to help. I really like async :).
My only comment on your gist<https://gist.github.com/3885941/ff5bfde7004061f5f6a879611a4d4f4cbffc0dce>is the fact that your http.get has the possibility to execute the queue callback up to 2 times. This is because you have it being calling in both the callback of the http.get and in the error event handler of the http.get. I'm not sure if the http callback still gets executed if you abort the request in the timeout. Note that if a request does call the error event, it will run the error handler and the http callback with a error in the first argument. And if you call the queue callback more than once in the same task it can/will spawn queue worker(s) above the concurrency limit if your queue is already saturated. And these queue workers will persist until the queue is empty/not saturated. Which could turn into a real problem with really large queues. Check out my queue test <https://gist.github.com/3888877>to demonstrate the above statement. Run it once as is, then uncomment line 15 and run again. See the difference in the concurrency of the tasks. Julian Lannigan On Sat, Oct 13, 2012 at 4:01 PM, Jason Venable <[email protected]>wrote: > And here it is with the timeout added back that does not kill every queued > up request. > > https://gist.github.com/3885941/ff5bfde7004061f5f6a879611a4d4f4cbffc0dce > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en > -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
