Have done some more work and amended changes to the commit. So far it's looking good and performing well. There are currently 3 TODO's in the comments for which I would appreciate help. Since these new methods are directly accessed from the SlowBuffer prototype, I imagine the assertion checks will have to be placed in the C code. That is mainly where I'm having problems.
trev On Sunday, December 23, 2012 10:22:03 PM UTC-8, Trevor Norris wrote: > > I've been working on a patch that will speed up read/write operations on > floating point numbers ( > https://github.com/trevnorris/node/compare/buffer-float). This is largely > based on the work from src/v8_typed_array.cc. There's still a lot I need to > fix up (e.g. the API, and support for NaN/Infinity values), but right now > floating point operations on Buffers are approx. 2x's faster than they > currently run on master. > > I would like some feedback, especially from committers, on how this could > be improved and if it would even be accepted. > -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
