On 13/02/13 13:20, Ben Noordhuis wrote:
> That's because the magic happens in test/simple/testcfg.py :-)

I see it - thanks!

>> Without it multiple tests fail (here, on Linux). test-cluster-http-pipe 
>> creates "test/tmp/test.sock" (from common.PIPE) but doesn't unlink it. The 
>> next test that tries to create the socket -
>> test-http-client-pipe-end - then fails with EADDRINUSE and so do several 
>> other subsequent tests.
>>
>> Maybe a better fix would be to implement the full clean-up in tools/test.py 
>> of the test/tmp/ directory after each test?
> 
> Strange, I'm not able to reproduce that.  (Unless I invoke the tests
> manually, of course.)

Nice! That means I've found another out-of-tree build issue. I've already 
corrected all the unit tests that were assuming
 source directory == build directory. It looks like:

SimpleTestCase.__init__()
self.tmpdir = join(dirname(self.config.root), 'tmp')

is pointing to the source directory.

I'll fix that up and add it to my out-of-tree-builds-auto-v4 branch.

Thanks for the pointer.

-- 
-- 
Job Board: http://jobs.nodejs.org/
Posting guidelines: 
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to