@Rich
Issue w/fix: https://github.com/joyent/node/issues/4375
Commit from Isaac
w/fix:
https://github.com/joyent/node/commit/4401bb47bfa4fe72c2755c428577903ece5cfaa0
The issue that Ben linked to, https://github.com/joyent/node/issues/5114, I
posted to the group for opinions on Friday
here: https://groups.google.com/forum/?fromgroups=#!topic/nodejs/ffXeRFp4KrE
At any rate, like Isaac said, in 0.10.x+ domains internally use
`process._fatalException` allowing domains to intercept errors before
emitting uncaughtException. Effectively allowing domains to suppress
uncaughtException events. Try it yourself:
$ node -e "process._fatalException = function(err) {console.log('here',
err.stack)}; null.foo"
It allows domains to avoid breaking mocha tests (which use
uncaughtException), etc...
Cheers,
Adam Crabtree
On Saturday, March 23, 2013 5:31:08 PM UTC-7, Isaac Schlueter wrote:
>
> In Node v0.8, domains were implemented using the
> process.on('uncaughtException') handler. So, yes, of course the
> uncaughtException would be fired, because that's how the Domain knows
> about the thrown error!
>
> In v0.10, we made Domains a bit more deeply involved in node's guts,
> so the uncaughtException event only happens if the domain does not
> handle the error.
>
> On Sat, Mar 23, 2013 at 11:11 AM, Rich Schiavi
> <[email protected]<javascript:>>
> wrote:
> > Thanks Ben, that link explains what I'm seeing...
> >
> > On Saturday, March 23, 2013 11:08:08 AM UTC-7, Ben Noordhuis wrote:
> >>
> >> On Sat, Mar 23, 2013 at 6:41 PM, Rich Schiavi <[email protected]>
> wrote:
> >> > i used to love nodejs because the community was very responsive ;-)
> >> >
> >> > this seems pretty basic. i can add a test if it helps. should domains
> >> > catch
> >> > all errors or should uncaught still get them?
> >>
> >> Code speaks more than words so yes, post a test case. :-)
> >>
> >> There is some discussion on the issue tracker on what domains should
> >> and should not catch, see e.g.
> >> https://github.com/joyent/node/issues/5114
> >
> > --
> > --
> > Job Board: http://jobs.nodejs.org/
> > Posting guidelines:
> > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
> > You received this message because you are subscribed to the Google
> > Groups "nodejs" group.
> > To post to this group, send email to [email protected]<javascript:>
> > To unsubscribe from this group, send email to
> > [email protected] <javascript:>
> > For more options, visit this group at
> > http://groups.google.com/group/nodejs?hl=en?hl=en
> >
> > ---
> > You received this message because you are subscribed to the Google
> Groups
> > "nodejs" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an
> > email to [email protected] <javascript:>.
> > For more options, visit https://groups.google.com/groups/opt_out.
> >
> >
>
--
--
Job Board: http://jobs.nodejs.org/
Posting guidelines:
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en
---
You received this message because you are subscribed to the Google Groups
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
