On Jul 2, 2013, at 03:47, Stephen Vickers wrote:
> On Tuesday, 2 July 2013 01:06:49 UTC+1, ryandesign wrote:
>
>> On Jul 1, 2013, at 14:41, Stephen Vickers wrote:
>>
>> > I've just published raw-socket 1.1.8 to npm.
>>
>> > This change does break existing code - hence this announcement - but the
>> > newer interface is much cleaner and (in my opinion) de-coupled, and I
>> > wanted to remove the old interface for some time now.
>>
>> Then shouldn't this have been 1.2.0? According to semver, the third number
>> in the version number is for bugfixes only and should never break existing
>> usage. Quoting from semver.org:
>>
>> > 6. Patch version Z (x.y.Z | x > 0) MUST be incremented if only backwards
>> > compatible bug fixes are introduced. A bug fix is defined as an internal
>> > change that fixes incorrect behavior.
>> >
>> > 7. Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backwards
>> > compatible functionality is introduced to the public API. It MUST be
>> > incremented if any public API functionality is marked as deprecated. It
>> > MAY be incremented if substantial new functionality or improvements are
>> > introduced within the private code. It MAY include patch level changes.
>> > Patch version MUST be reset to 0 when minor version is incremented.
>
> Yes, and my only excuse is tiredness :(
>
> Do you think I should pull 1.1.8 and upload 1.2.0, or just leave it as it is?
I have not published any npm packages myself and I don't know what the usual
practice is. But anybody who specified {"raw-socket": "~1.1.x"} for a
dependency in their package.json now might receive 1.1.8 which might break
their app, so to me it seems like you should unpublish 1.1.8, or maybe even
better: release a quick 1.1.9 to revert the backwards-incompatible change, then
release 1.2.0 with the change.
--
--
Job Board: http://jobs.nodejs.org/
Posting guidelines:
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en
---
You received this message because you are subscribed to the Google Groups
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
