Though it doesn't address the larger issue, that's definitely a better approach than forking request. Thanks. =)
I'd still prefer a better solution to the private npm issue though... Cheers, Adam Crabtree On Thu, Aug 22, 2013 at 2:48 PM, Kevin Swiber <[email protected]> wrote: > > > > On Thu, Aug 22, 2013 at 5:29 PM, Adam Crabtree <[email protected]>wrote: > >> Howdy all, >> >> We needed to fork forever-agent for some additional functionality, but >> don't want to have to fork request as well since we have made no updates to >> it, and would lose semver. >> >> Currently, the only way to accomplish this that I know of, would be to >> run a private npm repo that uses our private version for forever-agent and >> falls back on the public request, which feels like overkill. >> >> Is there a simpler solution? >> > > You could update your calling code to use whatever combination of > options.agent, options.agentClass, and options.agentOptions makes sense. > > https://github.com/mikeal/request/blob/master/request.js#L342-L352 > > If you wanted it to "just work" with no update to the code that calls > request, well... that's much trickier. > > -- > Kevin Swiber > Projects: https://github.com/kevinswiber > Twitter: @kevinswiber > > -- > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en > > --- > You received this message because you are subscribed to the Google Groups > "nodejs" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- Better a little with righteousness than much gain with injustice. Proverbs 16:8 -- -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en --- You received this message because you are subscribed to the Google Groups "nodejs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
