Thanks for the response. The pull request is here: https://github.com/joyent/node/pull/6294 . -Joshua Anderson
On Mon, Sep 30, 2013 at 10:17 AM, Ben Noordhuis <[email protected]> wrote: > On Mon, Sep 30, 2013 at 4:04 PM, A Random User <[email protected]> > wrote: > > Hello, > > > > I'm new to developing nodejs, though not programming it. I am in the > process > > of updating nodejs to support visual studio 2013. It's a three part > update: > > > > 1. Apply upstream patch to gyp to bump support to VS 2013 > > 2. Update vcbuild.bat to look for VS 2013 and compile with it > > 3.Update readme to mention support. > > > > I'm confused on the best way to update gyp. Should I just change the one > > file reguired for VS 2013 support? It appears in the past gyp has been > > bumped to a specific revision. If I should bump it to a revision, should > I > > jump it to the lowaest possible version (The commit where they added VS > > 2013) or the latest version. > > > > Also, should I leave VS2012 as the default compiler, or should I set > VS2013 > > to be the default one? > > > > Thanks for the advice! > > > > -Joshua Andersom > > Bumps of bundled dependencies are almost always done by committers > (e.g. me) because it's usually not feasible to audit the changes when > submitted as a pull request by a third party (e.g. you). > > When you open your pull request, just mention in the description that > it depends on a bump of gyp to revision X and me or someone else will > take care of it. > > I'd opt for keeping VS2012 as the default for now, it arguably has the > largest user base at this point. > > -- > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en > > --- > You received this message because you are subscribed to the Google Groups > "nodejs" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en --- You received this message because you are subscribed to the Google Groups "nodejs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
