surgemcgee,

Thanks for your work on this! It's good to see your work split into two 
modules -- the opendatabase wrapper split from the indurate library -- so 
that people can use one without the other if they want.

FWIW, the auto-generated openDatabase link under "dependencies" doesn't 
work because of the capital "D" -- apparently npm is case-sensitive (
https://npmjs.org/package/opendatabase/ works, but not 
https://npmjs.org/package/openDatabase/)

I'm a little surprised you chose a GPL license -- a more liberal license 
like MIT is more common for node libraries (sqlite itself is public 
domain), the GPL license would definitely make me think twice before using 
or contributing. It's totally your choice and you may have compelling or 
personal reasons; just wanted you to know my reaction because others will 
likely have the same reaction.

You might want to mention in the opendatabase readme the choice to spawn 
sqlite as a process, rather than use the sqlite3 C API, which I think would 
be the more common/expected approach. There are trade-offs to be aware of 
here, I'm no expert, but my understanding is that the C API will be faster 
and offer more flexibility/power and ability of the module to target a 
specific version of sqlite, but spawning a process will mean simpler and 
faster installation of your module (but require that sqlite be installed 
previously -- probably a given on linux/unix/mac but not Windows) and less 
disk space (no double installation of sqlite, if it's already on the 
system).

-- 
-- 
Job Board: http://jobs.nodejs.org/
Posting guidelines: 
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to