On Tue, May 27, 2014 at 12:11 AM, Stefano Baghino <[email protected]> wrote:

> At one point or another, someone is parsing that JSON. Are you sure that
> using require() this way is idiomatic enough for people to understand it
> when reading the code? I believe it would feel more natural if he
> explicitly opens the file and parses its content.
>

I agree.


> The only improvement I'd suggest would be to make it async, if possible.
>

That's not important if done once at startup time, when everything is
loaded sync anyway. It's only relevant if done inside an API call.

Matt.

-- 
Job board: http://jobs.nodejs.org/
New group rules: 
https://gist.github.com/othiym23/9886289#file-moderation-policy-md
Old group rules: 
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
--- 
You received this message because you are subscribed to the Google Groups 
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/nodejs/CAPJ5V2Z10Q%2B%3DFazd4Tw4Af27i3jJfufPYczBBD9xNydRp_7nfw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to