It's not clear from your email or the commit message what you think the bug is...
If you are referring to how it assumes the base of the domain is X.Y, there is a setting for that: - 'subdomain offset', which defaults to 2 - http://expressjs.com/api.html#app.settings.table If that's not what the bug you're seeing is, could you elaborate? ~Ryan On Fri, 10 Jul 2015 at 12:47 Aaron Gray <[email protected]> wrote: > Hi, > > I have found a bug possibly in node.js itself it manifests in > 'req.domains' not being setup correctly AFAICT. > > I have forked 'express-subdoamin' and added tests which demonstrate the > problem. > > https://github.com/AaronNGray/express-subdomain > > There is a 'debug' branch too that just prints out 'req.domains' in the > middleware 'subdomain' function. > > Looking at the tests there appears to be an addition problem with > 'express-subdomain' too, demonstrated by the first three tests. > > Hope someone can clarify this. > > -- > Aaron > > -- > Job board: http://jobs.nodejs.org/ > New group rules: > https://gist.github.com/othiym23/9886289#file-moderation-policy-md > Old group rules: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > --- > You received this message because you are subscribed to the Google Groups > "nodejs" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/nodejs/CANkmNDdwcXVVKvcvcFeEr6qNMzng3nTXn4EP_Zy3ExHxttb4PQ%40mail.gmail.com > <https://groups.google.com/d/msgid/nodejs/CANkmNDdwcXVVKvcvcFeEr6qNMzng3nTXn4EP_Zy3ExHxttb4PQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- Job board: http://jobs.nodejs.org/ New group rules: https://gist.github.com/othiym23/9886289#file-moderation-policy-md Old group rules: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines --- You received this message because you are subscribed to the Google Groups "nodejs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/nodejs/CAGjmZGx%3DBnR9M4gjrKP4r%3DbsFSRiOaO2sE%3DyE-kNSg%2Bux72uhg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
