On 08/29/2016 01:03 PM, Stephen Gallagher wrote: > On 08/29/2016 12:57 PM, Tom Hughes wrote: >> On 29/08/16 17:49, Stephen Gallagher wrote: >>> On 08/29/2016 12:46 PM, Tom Hughes wrote: >>>> The nodejs 6.5.0 build that is running now breaks v8 abi so binary >>>> extensions >>>> will need to be rebuilt. >>>> >>>> I've got my script ready to go and will run it for rawhide and f25 once >>>> the f25 >>>> build of nodejs completes - ideally we will then need to add those to the >>>> same >>>> bodhi update as nodejs for f25. >>> >>> It is an actual ABI *break*? Isn't that supposed to be forbidden? >> >> Well the v8 version changed from 5.0.71.60 to 5.1.281.81 which means our >> v8-abi >> provide has changed from 5.0 to 5.1 and caused dependencies to break in the >> binary modules. > > Ah, we should probably handle that similar to how we handle the Node.js ABI as > well, where we make the dependency based on supporting the major version > number > rather than the strict major-minor version.
Tom, do you want me to try to throw this together? I'm working on the EPEL 7 stuff right now and I'd prefer to land any change like this before we land it over there.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ nodejs mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
