On Tue, Dec 6, 2016 at 9:06 PM, Parag Nemade <[email protected]> wrote:

>
>
> On Tue, Dec 6, 2016 at 6:49 PM, Stephen Gallagher <[email protected]>
> wrote:
>
>> On 12/06/2016 12:11 AM, Parag Nemade wrote:
>> >
>> >
>> > On Tue, Dec 6, 2016 at 1:02 AM, Stephen Gallagher <[email protected]
>> > <mailto:[email protected]>> wrote:
>> >
>> >     As part of efforts around the Base Runtime, I'm working through
>> several FTBFS
>> >     issues in Node.js packages in Fedora 25. Most of these are due to
>> packages that
>> >     were built prior to the release of Node.js 6.5, which slightly
>> changed the
>> >     semantics of the test runner for expected results.
>> >
>> >     Most upstreams have a patch for this that works (occasionally with
>> minor
>> >     modifications), so I'm just pulling those down where possible and
>> otherwise
>> >     disabling the individual tests if not.
>> >
>> >     I do not plan to issue Bodhi updates for these changes; I only need
>> the builds
>> >     in Koji to pull them into the Base Runtime build environment.
>> >
>> >
>> >
>> > If you need any help in this work then I will be happy to do that.
>> >
>> > Parag.
>>
>> Parag, if you want to take a look at nodejs-grunt-contrib-watch, I
>> patched it to
>> just skip the tests. Maybe you can get them to work.
>>
>>
> Thanks. I will check that package and will see how to get tests working
> for it.
>

I found that there are 2 tests (livereload and nospawn) that are not
working but others are working fine. If we just remove them in %prep as

rm -f test/tasks/nospawn_test.js
rm -f test/tasks/livereload_test.js

then we can have other tests working for this package. I will check with
upstream on fixing these 2 tests.

Regards,
Parag.
_______________________________________________
nodejs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to