On Fri, Jun 5, 2020 at 12:29 PM Ben Rosser <[email protected]> wrote: > > On Fri, Jun 5, 2020 at 11:47 AM Troy Dawson <[email protected]> wrote: > > > > As much as I'd like 20 new nodejs packages, this seems like a good > > candidate for bundling. > > In short, update winston to the latest, and bundle it's dependencies, > > especially it's build dependencies. > > > > I'm not sure what to do about nodejs-prompt. > > Except to say that if you hadn't taken over nodejs-winston, it > > wouldn't be a happy package anyway. > > I guess bundling could work; how easy is this to do? Is there > documentation somewhere on the best way to bundle nodejs modules? Do > you just make a node_modules directory and copy them over? > > I think only a few are just build dependencies-- well, test > dependencies. abstract-winston-transport is required for both > winston-transport and winston's unit tests, and then std-mocks is also > required by winston's unit tests. > > Though, the real offender here is not winston but diagnostics, which > (in addition to the dependency on the React stack that I patched out!) > ended up needing about ~half of the new packages: > > nodejs-colorspace > nodejs-color > nodejs-color-convert > nodejs-color-name > nodejs-color-string > nodejs-color-name (again) > nodejs-simple-swizzle > nodejs-text-hex > nodejs-enabled > nodejs-kuler > > Also, it looks as though eventemitter3 and objstorage, which I built > in copr, are not actually required (they were needed for > storage-engine, which is the React piece of diagnostics I ended up up > scrapping). So, that's: > > * 18 total new node modules. > * nodejs-diagnostics and its 9 dependencies listed above are 10 of these. > * In addition to diagnostics, 6 new dependencies for winston itself: > winston-transport, logform, triple-beam, fast-safe-stringify, fecha, > one-time. (several of these are also required by winston).
Argh, typo: several of these are also required by winston-transport in addition to winston. Ben > * 2 test dependencies for nodejs-winston and/or > nodejs-winston-transport: std-mocks and abstract-winston-transport > > > Ben Rosser _______________________________________________ nodejs mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
