Hi all, Now that the packaging guidelines recommend bundling, I've resurrected my packaging effort for bitwarden-cli:
https://bugzilla.redhat.com/show_bug.cgi?id=1918111 I did a minor fix to the packaging guidelines: https://pagure.io/packaging-committee/c/126dc98c82ba2acffcc3b8ebd3984e5e3428685d?branch=master ... and had to update the bundler script in nodejs-packaging: https://src.fedoraproject.org/rpms/nodejs-packaging/pull-request/4 since bitwarden-cli is namespaced (the module is @bitwarden/cli) and the bundler script currently assumes the module name is a valid Unix filename. The package builds and runs fine (on x86_64, still need to test on ARM) but... quick question, is the `Provides: bundled(...)` supposed to work right now? I tried installing to %{nodejs_sitelib}/%{name} (bitwarden- cli) instead of to %{nodejs_sitelib}/%{npm_name} (@bitwarden/cli) thinking that that was why the bundled dependencies could not be found, but that did not seem to work. nodejs-packaging in Fedora is old - so maybe some of the updated macros have not landed yet? Not sure what to do with the bundled provides in the meanwhile, I suppose I could add them manually. Would appreciate a review, I expect the people here are the most familiar with all these edge cases. Best regards, -- Michel Alexandre Salim profile: https://keyoxide.org/[email protected] chat via email: https://delta.chat/ GPG key: 5DCE 2E7E 9C3B 1CFF D335 C1D7 8B22 9D2F 7CCC 04F2
signature.asc
Description: This is a digitally signed message part
_______________________________________________ nodejs mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
