Thanks. Applied and pushed. I also pushed a fix for the export strip function in Non Mixer.
On Wed, Jan 20, 2021 at 8:08 AM John Rigg <[email protected]> wrote: > Thanks for the quick reply. If it's a bug that explains why I couldn't > find where it was set to green in the code :-) > > Setting Background 1 in the black color scheme to RGB 4,4,4 or higher > with ntk-chtheme made the problem go away. > > I applied the workaround to lib/ntk/src/themes.cxx. Patch below. > > John > > > --- non/lib/ntk/src/themes.cxx 2021-01-15 15:43:01.000000000 +0000 > +++ non-mod/lib/ntk/src/themes.cxx 2021-01-20 11:13:34.316124487 +0000 > @@ -42,7 +42,7 @@ > > { > Fl_Color_Scheme *o = new Fl_Color_Scheme( "Black", > - fl_rgb_color( 0, 0, 0 ), > + fl_rgb_color( 4, 4, 4 ), > fl_rgb_color( 20, 20, > 20 ), > fl_rgb_color( 240, 240, > 240 ), > FL_YELLOW ); > > > On Tue, Jan 19, 2021 at 06:22:18PM -0800, J. Liles wrote: > > Sorry, I misread what you said. If the label background is green, then > the > > same thing applies re absolute black, but changing the theme color might > > not affect it. (although if you only see this in the black theme it > might). > > > > The code for setting the background color for that label should be in > > Audio_Region.C. Just look for all the ->color() calls and you'll probably > > find it if you want to force it to have a different value. I imagine it's > > set to FL_BLACK (perhaps from FL_BACKGROUND_COLOR in this case) and I > think > > it does have some opacity below 1 applied, which is, I believe, related > to > > the appearance of a green rather than black color. So you could also try > > setting the alpha to 1 (or 255), or the color to RGB 1,1,1 rather than > RGB > > 0,0,0. > > > > But I'd try fiddling with the theme colors first (via ntk-chtheme). > > > > > > On Tue, Jan 19, 2021 at 6:16 PM J. Liles <[email protected]> wrote: > > > > > Are you sure that was introduced in the last update? > > > > > > I have noticed this as well but have not had the time to track it down. > > > What's happening is that sometimes absolute black appears as this green > > > color. I think it may have something to do with opacity/alpha, because > pure > > > black isn't always green, just in some situations. > > > > > > I think if you set your scheme background manually (in ntk-chtheme or > from > > > the menu) to RGB 1,1,1 (just above absolute black), then the labels > will > > > turn from green to black as intended. > > > > > > On Tue, Jan 19, 2021 at 1:00 PM John Rigg <[email protected]> wrote: > > > > > >> I've been testing the recent updates and appreciating the > > >> numerous improvements. > > >> > > >> There's one usability regression however (for me). My eyes > > >> aren't what they used to be and I have problems with low > > >> contrast GUIs. I use the Black Cairo theme as it has good > > >> contrast and is dark enough to avoid eye fatigue with > > >> sustained use. > > >> > > >> Now in the Black color scheme the audio region filename > > >> labels, as well as the the tempo and time labels at the > > >> top, have a green background with white text (other color > > >> schemes use black bg which is fine). I have a particular > > >> problem with white on green contrast, making the labels > > >> almost unreadable here. > > >> > > >> I've spent a few hours looking through the source code, > > >> and have looked back through the GitHub history, but so > > >> far haven't been able to find where the label bg color is > > >> set. I'd like to change this on my local setup (and I'd > > >> be happy to post a patch if others would find it useful). > > >> > > >> A clue to where this bg color is set would be > > >> appreciated! > > >> > > >> John > > >> > > >> > > >> >
