[
https://issues.apache.org/jira/browse/GROOVY-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076125#comment-18076125
]
ASF GitHub Bot commented on GROOVY-11959:
-----------------------------------------
codecov-commenter commented on PR #2488:
URL: https://github.com/apache/groovy/pull/2488#issuecomment-4317561386
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2488?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 67.0897%. Comparing base
([`815e756`](https://app.codecov.io/gh/apache/groovy/commit/815e7566be4658a44956db4e303c61cf77421bf0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`84be989`](https://app.codecov.io/gh/apache/groovy/commit/84be9897da4a718f7c17ca338d5fc80c222a8ad3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2488 +/- ##
==================================================
+ Coverage 67.0889% 67.0897% +0.0008%
- Complexity 31588 31589 +1
==================================================
Files 1451 1451
Lines 122530 122533 +3
Branches 21996 21997 +1
==================================================
+ Hits 82204 82207 +3
+ Misses 33245 33243 -2
- Partials 7081 7083 +2
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2488?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...us/groovy/classgen/asm/BinaryExpressionHelper.java](https://app.codecov.io/gh/apache/groovy/pull/2488?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FBinaryExpressionHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9CaW5hcnlFeHByZXNzaW9uSGVscGVyLmphdmE=)
| `89.7004% <100.0000%> (+0.0582%)` | :arrow_up: |
... and [3 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2488/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> multi-assignment failure for singleton primitives
> -------------------------------------------------
>
> Key: GROOVY-11959
> URL: https://issues.apache.org/jira/browse/GROOVY-11959
> Project: Groovy
> Issue Type: Bug
> Reporter: Paul King
> Assignee: Paul King
> Priority: Major
>
> This example involving a primitive (and expected to fail since it's not an
> aggregate):
> {code:groovy}
> int z = 42
> def (x, y) = z
> {code}
> Gives:
> {noformat}
> java.lang.VerifyError: Bad local variable type
> Exception Details:
> Location:
> ConsoleScript20.run()Ljava/lang/Object; @31: aload_1
> Reason:
> Type integer (current frame, locals[1]) is not assignable to reference
> type
> Current Frame:
> bci: @31
> flags: { }
> locals: { 'ConsoleScript20', integer, 'java/lang/Object' }
> stack: { 'java/lang/Object', 'java/lang/Object' }
> Bytecode:
> 0000000: 102a 3c1b ba00 2f00 004d 2cba 0034 0000
> 0000010: ba00 3a00 0099 002d 2cba 003d 0000 592b
> 0000020: a500 214e 2cba 0034 0000 ba00 3a00 0099
> 0000030: 000c 2cba 003d 0000 a700 0401 3a04 a700
> 0000040: 1557 1b03 ba00 4200 004e 1b04 ba00 4200
> 0000050: 003a 041b b800 48b0
> Stackmap Table:
> append_frame(@59,Integer,Object[#77],Object[#77])
> same_locals_1_stack_item_frame(@60,Object[#77])
> full_frame(@65,{Object[#2],Integer,Object[#77]},{Object[#77]})
> same_frame(@66)
> append_frame(@83,Object[#77],Object[#77])
> at java.base/java.lang.Class.getDeclaredConstructors0(Native Method)
> at
> java.base/java.lang.Class.privateGetDeclaredConstructors(Class.java:3375)
> at java.base/java.lang.Class.getConstructor0(Class.java:3580)
> at java.base/java.lang.Class.getConstructor(Class.java:2273)
> at
> org.codehaus.groovy.runtime.InvokerHelper.newScript(InvokerHelper.java:498)
> {noformat}
> This:
> {code:groovy}
> Integer z = 42
> def (x, y) = z
> {code}
> Gives this as expected:
> {noformat}
> groovy.lang.MissingMethodException: No signature of method: getAt for class:
> java.lang.Integer is applicable for argument types: (Integer) values: [0]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
