[
https://issues.apache.org/jira/browse/GROOVY-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076211#comment-18076211
]
ASF GitHub Bot commented on GROOVY-11965:
-----------------------------------------
codecov-commenter commented on PR #2490:
URL: https://github.com/apache/groovy/pull/2490#issuecomment-4319524998
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2490?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `75.00000%` with `1 line` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 67.1244%. Comparing base
([`815e756`](https://app.codecov.io/gh/apache/groovy/commit/815e7566be4658a44956db4e303c61cf77421bf0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`f4ff351`](https://app.codecov.io/gh/apache/groovy/commit/f4ff351933eb0dab6c7c9c41ab310fda69496460?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 19 commits behind head on master.
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2490?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...y/tools/groovydoc/antlr4/GroovydocJavaVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2490?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2Fantlr4%2FGroovydocJavaVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL2FudGxyNC9Hcm9vdnlkb2NKYXZhVmlzaXRvci5qYXZh)
| 75.0000% | [0 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2490 +/- ##
==================================================
+ Coverage 67.0889% 67.1244% +0.0355%
- Complexity 31588 31605 +17
==================================================
Files 1451 1451
Lines 122530 122492 -38
Branches 21996 21997 +1
==================================================
+ Hits 82204 82222 +18
+ Misses 33245 33192 -53
+ Partials 7081 7078 -3
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2490?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...y/tools/groovydoc/antlr4/GroovydocJavaVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2490?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2Fantlr4%2FGroovydocJavaVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL2FudGxyNC9Hcm9vdnlkb2NKYXZhVmlzaXRvci5qYXZh)
| `69.9248% <75.0000%> (+4.2760%)` | :arrow_up: |
... and [6 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2490/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> groovydoc incorrectly includes members declared inside anonymous Java class
> bodies in the generated documentation of the enclosing class
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-11965
> URL: https://issues.apache.org/jira/browse/GROOVY-11965
> Project: Groovy
> Issue Type: Bug
> Reporter: Daniel Sun
> Priority: Major
> Attachments: Sql (Groovy 6.0.0-SNAPSHOT).html
>
>
> A visible example for {{groovy.sql.Sql}} is attached, whose generated
> groovydoc currently shows duplicate {{getType}} and duplicate {{getValue}}
> methods.
> These methods are not declared by {{Sql}} itself. They come from anonymous
> implementations used internally by helper methods such as in(...) and
> inout(...), but the Java-side groovydoc visitor traverses those anonymous
> class
> bodies and attaches their members to the enclosing class doc.
> *Expected behavior*
> Only members actually declared by the enclosing type should appear in its
> groovydoc. Members from anonymous class bodies should remain implementation
> details and must not be rendered as part of the outer class API.
> *Impact*
> This produces incorrect API documentation, introduces duplicate method
> entries, and makes affected Java classes appear to expose members they do not
> actually declare.
> *Notes*
> The issue is structural and is not limited to getType / getValue; other
> methods, fields, constructors, or local types inside anonymous class bodies
> may also leak into generated docs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
