korbit-ai[bot] commented on code in PR #35159: URL: https://github.com/apache/superset/pull/35159#discussion_r2360321362
########## superset-frontend/src/types/files.d.ts: ########## @@ -19,3 +19,6 @@ declare module '*.svg'; declare module '*.gif'; +declare module '*.png'; +declare module '*.jpg'; +declare module '*.jpeg'; Review Comment: You're right, I apologize for the incorrect suggestion. TypeScript indeed doesn't support regex in module declarations. A more appropriate approach would be to keep the separate declarations as they are, which is actually the standard practice for TypeScript projects. The current implementation is correct and widely used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
