msyavuz opened a new pull request, #35196:
URL: https://github.com/apache/superset/pull/35196

   ## Summary
   
   This PR migrates 5 core JavaScript files to TypeScript as part of the 
ongoing JS-to-TS migration effort.
   
   ### Migrated Files:
   - `src/utils/common.js` → `src/utils/common.ts`
   - `src/utils/reducerUtils.js` → `src/utils/reducerUtils.ts`
   - `src/middleware/loggerMiddleware.js` → `src/middleware/loggerMiddleware.ts`
   - `src/explore/store.js` → `src/explore/store.ts`
   - `src/dashboard/util/newComponentFactory.js` → 
`src/dashboard/util/newComponentFactory.ts`
   
   ## Testing Instructions
   
   1. Run the frontend build to ensure TypeScript compilation succeeds:
      ```bash
      npm run build
      ```
   
   2. Run the existing tests:
      ```bash
      npm run test
      ```
   
   3. Verify the application still works:
      - Navigate to Explore view and create/edit charts
      - Check dashboard functionality
      - Verify logging middleware is working
   
   ## Additional Information
   
   ### TypeScript Improvements:
   - Added comprehensive type definitions and interfaces
   - No `any` types used - follows Superset TypeScript conventions
   - Maintains full backward compatibility
   - All existing imports continue to work without modification
   
   ### Pre-commit Validation:
   - ✅ ESLint passes
   - ✅ Prettier formatting applied
   - ✅ TypeScript compiler checks pass
   
   🤖 Generated with [Claude Code](https://claude.ai/code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to