Re: [PR] fix(modals): restore App wrapper to fix Modal.confirm dark mode theming [superset]

[via GitHub]

korbit-ai[bot] commented on code in PR #35198:
URL: https://github.com/apache/superset/pull/35198#discussion_r2361398752


##########
superset-frontend/src/pages/ThemeList/index.tsx:
##########
@@ -112,6 +112,9 @@ function ThemesList({
   const [importingTheme, showImportModal] = useState<boolean>(false);
   const [appliedThemeId, setAppliedThemeId] = useState<number | null>(null);
 
+  // Use Modal.useModal hook to ensure proper theming
+  const [modal, contextHolder] = Modal.useModal();

Review Comment:
   ### Inconsistent modal theming implementation <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The Modal.useModal hook is declared but the modal instance is not being used 
consistently throughout the component - only in the showThemeConfirmation 
function while other modal usage patterns remain unchanged.
   
   
   ###### Why this matters
   This creates inconsistent theming behavior where some modals (those using 
the new modal.confirm) will have proper theming while others (like DeleteModal 
and ConfirmStatusChange) will still have theming issues, defeating the purpose 
of the change.
   
   ###### Suggested change ∙ *Feature Preview*
   Ensure all modal instances in the component use the same theming approach. 
Since DeleteModal and ConfirmStatusChange are separate components that likely 
need their own theming fixes, the current implementation is actually correct 
for the Modal.confirm usage. However, verify that all Modal.confirm calls are 
replaced with modal.confirm - currently only the showThemeConfirmation function 
uses it correctly.
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/18726350-f0d7-4ddf-bb22-c5a7359a933a/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/18726350-f0d7-4ddf-bb22-c5a7359a933a?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/18726350-f0d7-4ddf-bb22-c5a7359a933a?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/18726350-f0d7-4ddf-bb22-c5a7359a933a?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/18726350-f0d7-4ddf-bb22-c5a7359a933a)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:3cb75775-6598-43ce-a5e1-a3425c5ca9c2 -->
   
   
   [](3cb75775-6598-43ce-a5e1-a3425c5ca9c2)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org