[ 
https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462986#comment-13462986
 ] 

Keith Turner commented on ACCUMULO-765:
---------------------------------------

bq. or is the new lookupInstanceName that takes the fate ZooCache OK, since the 
core ZooCache extending the fate ZooCache should work in the new method?

It seems like the new method would be ok with the proposed extension.  It would 
be nice to test it.  Could compile code against 1.4 that uses that method, and 
then run the compiled code against 1.5.
                
> Compare 1.4 and 1.5 API
> -----------------------
>
>                 Key: ACCUMULO-765
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-765
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Keith Turner
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 
> 1.5 API changes.
> I just ran it and saw alow of diffs.  This may be because of removal of 
> deprecated methods.  I am going to attempt to improve the script to show 
> whats deprecated in 1.4. Also I may attempt to make it produce a report that 
> would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation.  Need 
> to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 
> diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance  
> 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance  
> 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
>      public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, 
> java.lang.String, int);
>      public org.apache.accumulo.core.conf.AccumuloConfiguration 
> getConfiguration();
>      public static java.lang.String 
> getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> -    public static java.lang.String 
> lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, 
> java.util.UUID);
> +    public static java.lang.String 
> lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, 
> java.util.UUID);
>      public void 
> setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to