[
https://issues.apache.org/jira/browse/ACCUMULO-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552776#comment-13552776
]
Keith Turner commented on ACCUMULO-956:
---------------------------------------
I am looking at the patch.
In the unit test the way it sets the transformation the scan should do is a bit
odd. It sets a static var. This is non-standard and only works because the
transformation is running in the same JVM. I think it would be better to make
the unit test representative of how you expect it to be used. Make different
iterators that do specific transformations, setup different scanners to use
those, and drop the KeyTransformer interface in the unit test.
> Iterator to transform key parts
> -------------------------------
>
> Key: ACCUMULO-956
> URL: https://issues.apache.org/jira/browse/ACCUMULO-956
> Project: Accumulo
> Issue Type: Improvement
> Reporter: Brian Loss
> Fix For: 1.5.0
>
> Attachments: key_transforming_iterator-1.patch,
> key_transforming_iterator.patch
>
>
> Iterators that transform parts of the key can be tricky if any transformation
> affects sort ordering. Implement an iterator that takes care of the tricky
> details that come with modifying sort order (e.g., handling scan-time
> iterator reconstruction and the associated seek).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira