[ 
https://issues.apache.org/jira/browse/ACCUMULO-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559883#comment-13559883
 ] 

Hudson commented on ACCUMULO-769:
---------------------------------

Integrated in Accumulo-Trunk-Hadoop-2.0 #11 (See 
[https://builds.apache.org/job/Accumulo-Trunk-Hadoop-2.0/11/])
    ACCUMULO-769 Modify mapreduce API to use the Hadoop static configurator 
conventions, but done in a way that allows us to standardize and reuse 
configurator code to support multiple frameworks. (Revision 1437073)

     Result = SUCCESS
ctubbsii : 
Files : 
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/cli/ClientOnDefaultTable.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/cli/ClientOnRequiredTable.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormat.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/util
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/util/ConfiguratorBase.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/util/FileOutputConfigurator.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/util/InputConfigurator.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/util/OutputConfigurator.java
* 
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/util/package-info.java
* 
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormatTest.java
* 
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormatTest.java
* 
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormatTest.java
* 
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormatTest.java
* 
/accumulo/trunk/examples/simple/src/test/java/org/apache/accumulo/examples/simple/filedata/ChunkInputFormatTest.java
* 
/accumulo/trunk/server/src/main/java/org/apache/accumulo/server/metanalysis/IndexMeta.java
* 
/accumulo/trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/CopyTool.java
* 
/accumulo/trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/MapRedVerifyTool.java

                
> MapReduce API should not use Configuration to set Job state at submission 
> time (ambiguous semantics)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-769
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-769
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.4.1, 1.4.0
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> ACCUMULO-267 made this change, but I think it was the wrong way to go about 
> it.
> From the comments on ACCUMULO-267:
> This is the wrong way to go about doing this fix. The reason why it took a 
> JobContext is so that it could accept a "Job" object. This was modeled after 
> the pattern Hadoop was using for FileOutputFormat, which is somewhat the 
> standard for conventions in configuring MR jobs.
> While JobContext does specifically state that's what it's purpose is, it is a 
> base class, and Job extends JobContext, and includes a comment that describes 
> it as holding the state of the job at submission time. This API should really 
> be taking a "Job" object, rather than a "JobContext" object. Further, because 
> Job is the only JobContext that actually works as intended here, the change 
> from JobContext to Job does not require any deprecation, because Job will 
> still work, and any other JobContext that isn't a Job will still fail. (We 
> would have to deprecate the ones that were added in 1.4 that took a 
> Configuration object, though... because those were never "correct", if we are 
> going off of the conventions set by Hadoop's provided OutputFormats).
> It is somewhat annoying to deprecate something in 1.5 that was added in 
> 1.4... especially since it allows people to go back to what they were doing 
> before. But, I think it might be worth it to be consistent with the 
> established conventions, and to clarify the semantics of the methods (we are, 
> after all, modifying the state of a job we are about to submit, and not just 
> an arbitrary configuration, which is used for all sorts of things).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to