[ 
https://issues.apache.org/jira/browse/ACCUMULO-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13578761#comment-13578761
 ] 

Keith Turner commented on ACCUMULO-842:
---------------------------------------

Damon the latest patch looks good. A few more comments.

 * The patch introduced some java warnings, like unused imports.   Does not 
bother me but introducing java warnings bugs some of the other committers. 
 * The commands accept and ignore extra arguments.  For example it will take 
"fate print foo" or "fate delete 6cf5ff841bcab678 0146bbf43749e62f".
 * I agree with the comment Eric made.   Give the ability to to supply the 
secret as an option.  If supplied, do not try to read local config file.

I like just adding new patches to a ticket, rather than replacing patches.   
Like FateCommand-1.patch, FateCommand-2.patch, etc.   I think it can makes 
following the discussion in the comments easier if someone is trying to 
correlate comments with a patch.  But thats jsut my personal preference.
                
> Fate operations should be rolled into shell
> -------------------------------------------
>
>                 Key: ACCUMULO-842
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-842
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: shell
>            Reporter: John Vines
>            Assignee: Damon A. Brown
>            Priority: Minor
>         Attachments: FateCommand.patch
>
>
> Fate is nifty but the only ways to deal with it are by directly calling some 
> utility jars. We should roll this functionality into the shell to make it 
> easier to manage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to