[ 
https://issues.apache.org/jira/browse/ACCUMULO-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633098#comment-13633098
 ] 

Keith Turner commented on ACCUMULO-1237:
----------------------------------------

I took a look at patch #2.   

 * Unit test did not run :  java.io.FileNotFoundException: 
/tmpminicluster-86bb2ad0-5ae9-479f-8fd1-f257d1d57553/conf/accumulo-site.xml (No 
such file or directory) 
 * if you are using eclipse, can you organize imports?
 * source code formatting seems incorrect
 * why not just do "loggerProcess = exec(LogService.class);" with no try/catch?
 * would probably be good to take 'appendProp(fileWriter, 
"logger.sort.buffer.size", "50M", siteConfig)' from instamo, but use the 
constant :    
                
> Back port the MiniAccumuloCluster from 1.5 to 1.4.*
> ---------------------------------------------------
>
>                 Key: ACCUMULO-1237
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1237
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: test
>            Reporter: Corey J. Nolet
>            Assignee: Corey J. Nolet
>            Priority: Minor
>             Fix For: 1.4.4
>
>         Attachments: ACCUMULO-1237-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to