[
https://issues.apache.org/jira/browse/ACCUMULO-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650414#comment-13650414
]
Hudson commented on ACCUMULO-1382:
----------------------------------
Integrated in Accumulo-Trunk #851 (See
[https://builds.apache.org/job/Accumulo-Trunk/851/])
ACCUMULO-1382 Make PairLexicoder use a ComparablePair, so the
Comparable-ness of its parameters can be enforced. Also fixed javadocs, header
comments, formatting, and warnings introduced by ACCUMULO-1336. (Revision
1479448)
Result = SUCCESS
ctubbsii :
Files :
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/BigIntegerLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/BytesLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/DateLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/DoubleLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/Encoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/IntegerLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/Lexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/ListLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/LongLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/PairLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/ReverseLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/StringLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/TextLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/UIntegerLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/ULongLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/UUIDLexicoder.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/util/ByteUtils.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/lexicoder/util/FixedByteArrayOutputStream.java
*
/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/ComparablePair.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/Pair.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/BigIntegerLexicoderTest.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/DoubleLexicoderTest.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/IntegerLexicoderTest.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/LexicoderTest.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/ListLexicoderTest.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/LongLexicoderTest.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/PairLexicoderTest.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/ReverseLexicoderTest.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/UIntegerLexicoderTest.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/ULongLexicoderTest.java
*
/accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/lexicoder/UUIDLexicoderTest.java
*
/accumulo/trunk/server/src/main/java/org/apache/accumulo/server/mini/MiniAccumuloConfig.java
> Pair incorrectly assumes its components are Comparable
> ------------------------------------------------------
>
> Key: ACCUMULO-1382
> URL: https://issues.apache.org/jira/browse/ACCUMULO-1382
> Project: Accumulo
> Issue Type: Bug
> Reporter: Christopher Tubbs
> Assignee: Christopher Tubbs
> Labels: warning
> Fix For: 1.6.0
>
>
> In trunk (for 1.6.0), Pair<A,B> was made Comparable, but makes assumptions
> that A and B are Comparable. This should either be checked in its compareTo
> method explicitly, or should be enforced in the generic parameters. This
> assumption is a runtime bug-in-waiting.
> It looks like this was added to support some of the new Lexicoders.
> I did a rough check to see the implications of enforcing the parameters to be
> Comparable (changing it from Pair<A,B> to Pair<A extends Comparable<A>,B
> extends Comparable<B>>), and it looks like there's a problem because we use
> this class with generated thrift code, which are not Comparable objects.
> It might be better to make a ComparablePair that extends Pair, for use in the
> Lexicoders, instead of making Pair itself Comparable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
