[
https://issues.apache.org/jira/browse/ACCUMULO-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651978#comment-13651978
]
Keith Turner commented on ACCUMULO-1357:
----------------------------------------
Thanks again [~sonixbp]! Looking at patch #1, I think enabling debugging should
be a method on MAConfig. If its a method on MACluster then it should throw
illegal state exception if called after start(). By putting it in the config
object, it makes it more clear that it can not be enabled after start() it
called.
IMO ServerType should be in the mini package, its part of the MAC API.
For setting memory, should we make that more strongly typed and less error
prone? One way to do that is to use the Java TimeUnit convention. Maybe
something like the following :
{code:java}
enum MemoryUnit {
BYTE,
KILOBYTE,
MEGABYTE,
GIGABYTE,
etc
}
class MiniAccumuloConfig {
.
.
.
public MiniAccumuloConfig setMemory(ServerType, long memory, MemoryUnit
unit ){}
}
{code}
Maybe this is not that useful if this usually ends up coming from a config
file. If we do not do something more stronly typed, then we should at least
validate the String passed into the set method immediately so that it fails
fast.
> Make debugging MiniAccumuloCluster easier
> -----------------------------------------
>
> Key: ACCUMULO-1357
> URL: https://issues.apache.org/jira/browse/ACCUMULO-1357
> Project: Accumulo
> Issue Type: Improvement
> Reporter: Keith Turner
> Assignee: Corey J. Nolet
> Fix For: 1.6.0
>
> Attachments: ACCUMULO-1357.1.patch
>
>
> When a problem occurs with MiniAccumuloCluster it can be difficult to debug.
> Something that may make this easier.
> * The ability to easily access log files. (maybe have a method users could
> call to copy log files to a target dir).
> * Starting Accumulo server processes with remote JVM debugging enabled.
> (this could be a statup option, could have method users could call to get the
> debug ports)
> It would be nice if a unit test fails in a maven run if the MiniAcc logs
> files would end up the target dir that contains info about test failures.
> Make it as easy as possible to do this from junit test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira