[ 
https://issues.apache.org/jira/browse/ACCUMULO-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Vines updated ACCUMULO-1505:
---------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Looks good. I went ahead and applied it to 1.4.4, 1.5.1, and 1.6.0. There was a 
typing warning from the use of Collection.EMPTY_LIST that I fixed. 
Additionally, updated it to use the new APIs for 1.5.0+.

I also added you as a contributor, Ryan. Thanks again!
                
> MockTable's addMutation does not check for empty mutation
> ---------------------------------------------------------
>
>                 Key: ACCUMULO-1505
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1505
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.4.3
>            Reporter: Ryan Leary
>            Assignee: Ryan Leary
>             Fix For: 1.4.4, 1.5.1, 1.6.0
>
>         Attachments: accumulo1505.patch
>
>
> When calling addMutation or addMutations on a MockBatchWriter, the updates 
> stored in the mutation are iterated over then committed in the MockTable 
> class. 
> When this occurs in the TabletServerBatchWriter (eventually called from the 
> BatchWriterImpl), however, the mutation size is first checked and if the 
> mutation size is 0, an IllegalArgumentException is thrown.
> In practice, if you have code that tries to submit an empty mutation to a 
> BatchWriter, it will fail and throw an exception in the real world, but this 
> will not be caught in tests against MockAccumulo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to