[
https://issues.apache.org/jira/browse/ACCUMULO-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715248#comment-13715248
]
Keith Turner commented on ACCUMULO-1588:
----------------------------------------
[~jklucar] answered my question, the constructor in
o.a.a.server.monitor.servlets.jaxb.Stats() populates the POJOs.
This patch is nice, it really cleans up the monitor code. As far as test, that
would be excellent. Howerver the monitor does not currently have a lot of
test, so I am thinking it should not be a requirement for this patch? Test
for things that can easily be verified would great. For example if you know a
table A has 10 tablets and table B has 3 tablets, does the XML accurately
reflect this. Some things like # running compactions would difficult to verify
in an intergration tests, maybe easier in a unit test that does not excecise
full functionality. [~jklucar] if you do plan to implement test, let me know
and I will hold off looking into this patch more. If there are no test I would
like to closely review the code that populates the POJOs before applying it.
> Monitor XML and JSON differ
> ---------------------------
>
> Key: ACCUMULO-1588
> URL: https://issues.apache.org/jira/browse/ACCUMULO-1588
> Project: Accumulo
> Issue Type: Bug
> Components: monitor
> Affects Versions: 1.5.0
> Reporter: Jim Klucar
> Priority: Minor
> Labels: monitor
> Fix For: 1.6.0
>
> Attachments: ACCUMULO-1588.patch
>
>
> The monitor XML and JSON servlets differ greatly in what data they contain.
> The data should be gathered into JAXB POJOs in both servlets, and just
> serialzed differently so we're guaranteed to get the same data in both.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
