[
https://issues.apache.org/jira/browse/ACCUMULO-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764616#comment-13764616
]
Steve Loughran commented on ACCUMULO-1709:
------------------------------------------
There's no test for this patch, here is a before and after log in a program
forking accumulo (hence the log4j in log4j trace)
{code}
shutdown of the AM: Spawned master exited with raw 0 mapped to 0
2013-09-11 19:07:07,489 ERROR (RunLongLivedApp.java:run(408)) -
2013-09-11 19:07:07,489 INFO (RunLongLivedApp.java:run(419)) -
2013-09-11 19:07:07,489 INFO (RunLongLivedApp.java:run(422)) - 2013-09-11
19:07:07,386 [zookeeper.ZooUtil] ERROR: unable obtain instance id at
file:/accumulo/instance_id
2013-09-11 19:07:07,489 INFO (RunLongLivedApp.java:run(422)) - 2013-09-11
19:07:07,386 [master.Master] ERROR: Unexpected exception, exiting
2013-09-11 19:07:07,489 INFO (RunLongLivedApp.java:run(422)) -
java.lang.RuntimeException: Accumulo not initialized, there is no instance id
at file:/accumulo/instance_id
2013-09-11 19:07:07,489 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.core.zookeeper.ZooUtil.getInstanceIDFromHdfs(ZooUtil.java:60)
2013-09-11 19:07:07,489 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.client.HdfsZooInstance._getInstanceID(HdfsZooInstance.java:125)
2013-09-11 19:07:07,490 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.client.HdfsZooInstance.getInstanceID(HdfsZooInstance.java:119)
2013-09-11 19:07:07,490 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.conf.ZooConfiguration.getInstance(ZooConfiguration.java:54)
2013-09-11 19:07:07,490 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.conf.ServerConfiguration.getZooConfiguration(ServerConfiguration.java:50)
2013-09-11 19:07:07,490 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.conf.ServerConfiguration.getSystemConfiguration(ServerConfiguration.java:59)
2013-09-11 19:07:07,490 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.fs.VolumeManagerImpl.get(VolumeManagerImpl.java:312)
2013-09-11 19:07:07,490 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.master.Master.main(Master.java:1635)
2013-09-11 19:07:07,490 INFO (RunLongLivedApp.java:run(422)) - at
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2013-09-11 19:07:07,490 INFO (RunLongLivedApp.java:run(422)) - at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
2013-09-11 19:07:07,490 INFO (RunLongLivedApp.java:run(422)) - at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
2013-09-11 19:07:07,490 INFO (RunLongLivedApp.java:run(422)) - at
java.lang.reflect.Method.invoke(Method.java:597)
2013-09-11 19:07:07,491 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.start.Main$1.run(Main.java:107)
2013-09-11 19:07:07,491 INFO (RunLongLivedApp.java:run(422)) - at
java.lang.Thread.run(Thread.java:680)
2013-09-11 19:07:07,563 [main] DEBUG appmaster.HoyaAppMaster
(HoyaAppMaster.java:finish(747)) - Stopping forked process: exit code=0
{code}
After
{code}
2013-09-11 19:35:02,887 INFO (RunLongLivedApp.java:run(419)) -
2013-09-11 19:35:02,888 INFO (RunLongLivedApp.java:run(422)) - 2013-09-11
19:35:02,737 [zookeeper.ZooUtil] ERROR: unable obtain instance id at
file:/accumulo/instance_id
2013-09-11 19:35:02,888 INFO (RunLongLivedApp.java:run(422)) - 2013-09-11
19:35:02,737 [master.Master] ERROR: Unexpected exception, exiting
2013-09-11 19:35:02,888 INFO (RunLongLivedApp.java:run(422)) -
java.lang.RuntimeException: Accumulo not initialized, there is no instance id
at file:/accumulo/instance_id
2013-09-11 19:35:02,888 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.core.zookeeper.ZooUtil.getInstanceIDFromHdfs(ZooUtil.java:60)
2013-09-11 19:35:02,888 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.client.HdfsZooInstance._getInstanceID(HdfsZooInstance.java:125)
2013-09-11 19:35:02,888 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.client.HdfsZooInstance.getInstanceID(HdfsZooInstance.java:119)
2013-09-11 19:35:02,888 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.conf.ZooConfiguration.getInstance(ZooConfiguration.java:54)
2013-09-11 19:35:02,888 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.conf.ServerConfiguration.getZooConfiguration(ServerConfiguration.java:50)
2013-09-11 19:35:02,888 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.conf.ServerConfiguration.getSystemConfiguration(ServerConfiguration.java:59)
2013-09-11 19:35:02,888 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.fs.VolumeManagerImpl.get(VolumeManagerImpl.java:312)
2013-09-11 19:35:02,889 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.server.master.Master.main(Master.java:1635)
2013-09-11 19:35:02,889 INFO (RunLongLivedApp.java:run(422)) - at
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2013-09-11 19:35:02,889 INFO (RunLongLivedApp.java:run(422)) - at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
2013-09-11 19:35:02,889 INFO (RunLongLivedApp.java:run(422)) - at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
2013-09-11 19:35:02,889 INFO (RunLongLivedApp.java:run(422)) - at
java.lang.reflect.Method.invoke(Method.java:597)
2013-09-11 19:35:02,889 INFO (RunLongLivedApp.java:run(422)) - at
org.apache.accumulo.start.Main$1.run(Main.java:107)
2013-09-11 19:35:02,889 INFO (RunLongLivedApp.java:run(422)) - at
java.lang.Thread.run(Thread.java:680)
2013-09-11 19:35:03,522 [main] DEBUG appmaster.HoyaAppMaster
(HoyaAppMaster.java:finish(747)) - Stopping forked process: exit code=1
{code}
The exit code is being picked up successfully after the patch is applied
> failing Master doesn't set exit code of process
> -----------------------------------------------
>
> Key: ACCUMULO-1709
> URL: https://issues.apache.org/jira/browse/ACCUMULO-1709
> Project: Accumulo
> Issue Type: Bug
> Affects Versions: 1.6.0
> Reporter: Steve Loughran
> Attachments: ACCUMULO-1709-001.patch
>
>
> If the master can't start up due to an exception, it logs it, but doesn't
> exit the process with any error code -so the failure isn't picked up by any
> scripts looking at the exit code of bin/accumulo
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
