[ 
https://issues.apache.org/jira/browse/ACCUMULO-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826201#comment-13826201
 ] 

Terry Porter commented on ACCUMULO-1901:
----------------------------------------

Thanks for your excellent reply Sean, I appreciate all the time you took and 
learned a lot from it. I've prepared the patch for 1.4.5 and will submit it in 
a second. I'd appreciate if you could take a look and see how I did.

If it looks right, do I repeat against the 1.5.1 and 1.6.0 Snapshots, or will 
you guys merge this patch into those branches?

> start-here.sh starts only one GC process even if more are defined
> -----------------------------------------------------------------
>
>                 Key: ACCUMULO-1901
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1901
>             Project: Accumulo
>          Issue Type: Bug
>          Components: gc, scripts
>    Affects Versions: 1.4.2, 1.4.3, 1.4.4, 1.5.0
>         Environment: Red Hat Enterprise Linux 6.3 64-bit
>            Reporter: Terry Porter
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Even when a second host is listed in the gc file, the gc process is only ever 
> started on the first host listed in the gc file.  The issue lies in lines 
> 48-55 in start-here.sh as shown below:
> {code}
> for host in $HOSTS
> do
>     if [ ${host} = ${GC} ]
>     then
>         ${bin}/start-server.sh $GC gc "garbage collector"
>         break
>     fi
> done
> {code}
> Simple fix:
> {code}
> for host in $HOSTS
> do
>     if grep -q "^${host}\$" $ACCUMULO_HOME/conf/gc
>     then
>         ${bin}/start-server.sh ${host} gc "garbage collector"
>         break
>     fi
> done
> {code}
> This fix works in my 1.4.2 environment.  stop-here.sh already sweeps all 
> possible processes to kill them, so no fix needed there.
> I posted the fix in case anyone needs this ASAP as this will be my first 
> development work with an open source project, but I hope to be able to post 
> the fix this weekend.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to