[ 
https://issues.apache.org/jira/browse/ACCUMULO-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843627#comment-13843627
 ] 

Josh Elser commented on ACCUMULO-1785:
--------------------------------------

I just noticed that these changes also impacted how ACCUMULO_HOME is used. I'm 
not sure if it was intentional or not.

Before these changes, bin/config.sh *always* calculated ACCUMULO_HOME based on 
the location of itself (config.sh). Since the changes for this issue, 
ACCUMULO_HOME is only calculated, when ACCUMULO_HOME is not already set or is 
set to the empty string.

>From an error-catching perspective, should we add something that does some 
>validation of the provided ACCUMULO_HOME when we don't calculate it? I can 
>easily see cases where the user mistypes an export of ACCUMULO_HOME or 
>programmatically generates an incorrect path and suddenly none of the 
>classpaths work.

> Alter config.sh to optionally just verify environment instead of making 
> changes
> -------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-1785
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1785
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 1.4.4, 1.5.0, 1.6.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>         Attachments: ACCUMULO-1785.1.patch.txt, ACCUMULO-1785.2.patch.txt
>
>
> Right now, the accumulo scripts presume that invocation always happens on a 
> node in the cluster. This makes integrating with external cluster management 
> software more difficult.
> The primary issue is that bin/config.sh expects to find a full cluster 
> configuration directory at all times. In the case of a configuration 
> directory that doesn't specify any hosts it takes steps to set up a 
> standalone cluster. That effort is unneeded and undesirable if we're just 
> e.g. trying to go through init from a non-participant host.
> Add an optional environment variable to have config.sh just verify the 
> invariants needed for bin/accumulo to behave correctly. When present, don't 
> make local directories or write to files.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to