[
https://issues.apache.org/jira/browse/ACCUMULO-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855893#comment-13855893
]
Ed Coleman commented on ACCUMULO-1910:
--------------------------------------
Yes, it is the dependency for accumulo-core. In the pom(s) for TestCombinerX,
Y the dependency for accumulo-core is set to (1.4.4,], overriding the project
version. For 1.5.1 I can compile just fine, so 1.5.1-SNAPSHOT works okay
(matches project version). This was just a work-around for me because
1.4.5-SNAPSHOT build was causing problems with docgen so I don't have
1.4.5-SNAPSHOT artifacts to compile against..
The sources end-up in the [Artifact]-sources.jar file - those have both the
class and the source (.java) file(s). So for ClassloaderA you should have had
both Test.jar and Test-sources.jar
I've probably over-thought this, but I didn't want to change existing artifacts
and it does not seem "natural" to have both class and java files in a jar used
at run-time? At least, that's what the maven sources plugin was leading me to
believe and rather than fight convention I thought it may be best to provide
both. I see that the test jars with source for 1.5.1 do have both, so... well,
didn't know which way to go. I thought we could provide both, or rename
[Artifact]-sources to [Artifact].jar and call it complete. (i.e. figured it is
easier to delete than to create). If the [Artifact]-source.jars are just
renamed, the whole sub-project thing could go away, but maybe they could be
useful if someone wanted to tweak the samples as a starting point?
---
Working on 1.5.1 and have FooConstraints mostly done, just need to get
HelloWorld2.
> Add source to jar files used for testing
> ----------------------------------------
>
> Key: ACCUMULO-1910
> URL: https://issues.apache.org/jira/browse/ACCUMULO-1910
> Project: Accumulo
> Issue Type: Task
> Components: test
> Affects Versions: 1.4.4, 1.5.0
> Reporter: Josh Elser
> Assignee: Ed Coleman
> Labels: newbie
> Fix For: 1.4.5, 1.5.1, 1.6.0
>
> Attachments: ACCUMULO-1910-1.4.5.patch
>
>
> Some of the jars we include for testing purposes have the source included.
> Some do not.
> It would be nice to make sure that we included the source for all of these
> jars, not just the class files.
> Jars in 1.4 with no source
> * ./src/start/src/test/resources/ClassLoaderTestA/Test.jar
> * ./src/start/src/test/resources/ClassLoaderTestB/Test.jar
> * ./src/start/src/test/resources/ClassLoaderTestC/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestA/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestB/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestC/Test.jar
> * ./test/system/auto/TestCombinerX.jar
> * ./test/system/auto/TestCombinerY.jar
> Jars in 1.5 and 1.6 with no source:
> * ./start/src/test/resources/ClassLoaderTestA/Test.jar
> * ./start/src/test/resources/ClassLoaderTestB/Test.jar
> * ./start/src/test/resources/ClassLoaderTestC/Test.jar
> * ./start/src/test/resources/HelloWorld2.jar
> * ./test/src/test/resources/FooConstraint.jar
> * ./test/system/auto/TestCombinerX.jar
> * ./test/system/auto/TestCombinerY.jar
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
