[
https://issues.apache.org/jira/browse/ACCUMULO-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ed Coleman updated ACCUMULO-1910:
---------------------------------
Attachment: test-jars-src.tgz
ACCUMULO-1910-1.6.0-SNAPSHOT.patch
ACCUMULO-1910-1.5.1-SNAPSHOT.patch
ACCUMULO-1910-1.4.5-SNAPSHOT.patch
These files contain the test jars with source (*.patch files) and also the
maven projects that I used to create them.
I created separate patches for each accumulo version so that they would be
clean and I would not wreck havoc if I tried to merge / pull them.
The tar with the maven project(s) are really just so that they can be archived
here (for when someone finds I made a mistake) but I don't expect they need to
be incorporated to any release branch. If test jar generators are going to be
include in future release, we should examine the approach, because this way is
much more difficult that it really needs to be.
A few notes and lessons learned:
The issue that I was having with 1.4.5-SNAPSHOT build appears to have been
because I had ACCUMULO_HOME set for my run-time environment. Un-setting that
variable was all that I needed to do.
The timeout errors that I received under 1.5.1-SNAPSHOT were do to an error in
the package name that I had for FooConstraint - I suspect the test were
throwing class-not-found exceptions, but the junit error that was reported look
like it was a timeout error in the test case. So no timeouts, just test errors
because of my mistake(s)
Not sure that mvn package tests use ClassLoader[B/C]. I had an error where I
copied ClassLoaderA/Test.jar to both B and C and only 1.4.5-SNAPSHOT seemed to
recognize the error.
Each generator project has a createJar directory with a createJar.sh script
that will run maven, copy the files to a temp directory outside of the maven
build path and then run the jar cvf command. The jar command was used instead
of maven plug-ins so that only the default manifest is included in the
resulting jar files.
> Add source to jar files used for testing
> ----------------------------------------
>
> Key: ACCUMULO-1910
> URL: https://issues.apache.org/jira/browse/ACCUMULO-1910
> Project: Accumulo
> Issue Type: Task
> Components: test
> Affects Versions: 1.4.4, 1.5.0
> Reporter: Josh Elser
> Assignee: Ed Coleman
> Labels: newbie
> Fix For: 1.4.5, 1.5.1, 1.6.0
>
> Attachments: ACCUMULO-1910-1.4.5-SNAPSHOT.patch,
> ACCUMULO-1910-1.5.1-SNAPSHOT.patch, ACCUMULO-1910-1.6.0-SNAPSHOT.patch,
> test-jars-src.tgz
>
>
> Some of the jars we include for testing purposes have the source included.
> Some do not.
> It would be nice to make sure that we included the source for all of these
> jars, not just the class files.
> Jars in 1.4 with no source
> * ./src/start/src/test/resources/ClassLoaderTestA/Test.jar
> * ./src/start/src/test/resources/ClassLoaderTestB/Test.jar
> * ./src/start/src/test/resources/ClassLoaderTestC/Test.jar
> * ./test/system/auto/TestCombinerX.jar
> * ./test/system/auto/TestCombinerY.jar
> Jars in 1.5 and 1.6 with no source:
> * ./start/src/test/resources/ClassLoaderTestA/Test.jar
> * ./start/src/test/resources/ClassLoaderTestB/Test.jar
> * ./start/src/test/resources/ClassLoaderTestC/Test.jar
> * ./start/src/test/resources/HelloWorld2.jar
> * ./test/src/test/resources/FooConstraint.jar
> * ./test/system/auto/TestCombinerX.jar
> * ./test/system/auto/TestCombinerY.jar
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
