[
https://issues.apache.org/jira/browse/ACCUMULO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860667#comment-13860667
]
Sean Busbey commented on ACCUMULO-1933:
---------------------------------------
Thanks Ted!
Could you update the new test file to include an ASF license header?
A few suggested improvements:
* how about IllegalArgumentException instead of generic RuntimeException?
* please break the two failure cases into their own tests that use JUnit's
expected exception argument to hte Test annotation
Also, please make sure you're creating the patch with the "git diff" args given
[in our contributor guide|http://accumulo.apache.org/git.html#contributors] so
that a committer can easily attribute the commit to you.
> Make unit on memory parameters case-insensitive
> -----------------------------------------------
>
> Key: ACCUMULO-1933
> URL: https://issues.apache.org/jira/browse/ACCUMULO-1933
> Project: Accumulo
> Issue Type: Improvement
> Components: shell
> Affects Versions: 1.4.5
> Reporter: Josh Elser
> Priority: Minor
> Labels: newbie
> Attachments: ACCUMULO-1933.patch
>
>
> {{config -t my_table -s table.split.threshold=2g}} fails with a non-intuitive
> error.
> {{config -t my_table -s table.split.threshold=2G}} succeeds
> It would be nice for both to work.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
