[
https://issues.apache.org/jira/browse/ACCUMULO-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868247#comment-13868247
]
Bill Havanki commented on ACCUMULO-2160:
----------------------------------------
Thanks for doing this. I'm a huge Findbugs fan. Some items that jumped out at
me:
* In several places you switched out {{Math.random()}} for
{{Random.nextInt()}}. It may be worthwhile creating a single {{Random}}
instance for all code to use, so that there aren't a bunch of them around. The
downside is that {{Random}} isn't thread-safe, so a shared instance would have
to be synchronized. I'll leave it to you whether that is an issue for
performance ({{Math.random()}} had to synchronize anyway).
* The change in the {{equals()}} methods of {{Condition}} and
{{ConditionalMutation}} mean that their subclasses can now be considered equal
to superinstances. That might matter, it might not.
* I saw some stubbed {{hashCode()}} methods, which makes sense for this ticket,
but we'll need to fix those.
* The correction in {{Authorizations.contains(String)}} seems like it could be
huge, since before it would always return false. Did that have any impact?
* The correction in {{TabletServer.AssignmentHandler.run()}} also seems like it
could have some significance in making {{recentlyUnloadedCache}} work better -
maybe causing more {{UNLOAD_FAILURE_NOT_SERVING}} messages to be generated.
(Looks like a good thing.)
> Run findbugs for 1.6
> --------------------
>
> Key: ACCUMULO-2160
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2160
> Project: Accumulo
> Issue Type: Task
> Reporter: Eric Newton
> Assignee: Eric Newton
> Fix For: 1.6.0
>
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
