[ 
https://issues.apache.org/jira/browse/ACCUMULO-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877535#comment-13877535
 ] 

Michael Wall commented on ACCUMULO-2100:
----------------------------------------

Sorry, I meant to answer that as well.  I was planning to add a Wrapper to the 
MiniAccumuloConfig as well to handle the new options.  I agree a better long 
term solution would be to roll this stuff into the MiniAccumuloCluster/Config.

Putting a wrapper on both objects in the archetype adds capability for already 
released versions and would allow new design to be tested.  Functionality could 
be moved to the MAC proper as it made sense.  Does this sound reasonable?

> instamo-archetype could use a little clean up
> ---------------------------------------------
>
>                 Key: ACCUMULO-2100
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2100
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: instamo-archetype
>            Reporter: Michael Wall
>            Assignee: Josh Elser
>            Priority: Minor
>
> Some of the things I noticed
> - mvn test fails, because it took longer than 30 secs to startup the MAC on 
> my linux box.
> - README needs to be updated, usage is incorrect
> - pom.xml doesn't hook exec:exec into any lifecycle so you have to call mvn 
> compile exec:exec -Pwhatever
> - Could abstract out a MiniAccumuloClusterWrapper to handle the temp 
> directory clean up and make the usage across the ShellExample, 
> MapReduceExample and ExampleAccumuloUnitTest consistent.  Would also make it 
> easier to implement ACCUMULO-2097 and ACCUMULO-2098
> BTW, I am running this against the origin/1.5 branch, targeting an archetype 
> that is compatible with Accumulo 1.5.0
> Patch coming for review



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to