[
https://issues.apache.org/jira/browse/ACCUMULO-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880412#comment-13880412
]
Christopher Tubbs commented on ACCUMULO-2183:
---------------------------------------------
I must've missed the IRC conversation.
I think some effort was made to stop returning the thrift object in the getter
method for the code, as that is public API. Is that what you mean by "clean
break"? There's still somewhat of a link... because we need to translate
between the two when we construct the public API exception from the RPC/thrift
exception.
I'm not saying that there's a bug or anything here... I'm just saying that the
code is very confusing and has been prone to errors in the past due to the
history of the RPC/public API translation and the similarity in class names.
Since there's no compiler-check to ensure correctness with equals(Object), but
there is with switch statements, I'm just saying it might be a good idea to use
switch statements over equals for enum comparisons to avoid errors and ensure
the compiler checks for correctness.
> [RW] Error in Security.Validate
> -------------------------------
>
> Key: ACCUMULO-2183
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2183
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 1.5.1, 1.6.0
>
>
> {noformat}
> 11 12:02:58,543 [randomwalk.Framework] ERROR: Error during random walk
> java.lang.Exception: Error running node Security.xml
> at org.apache.accumulo.test.randomwalk.Module.visit(Module.java:285)
> at
> org.apache.accumulo.test.randomwalk.Framework.run(Framework.java:65)
> at
> org.apache.accumulo.test.randomwalk.Framework.main(Framework.java:125)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.apache.accumulo.start.Main$1.run(Main.java:103)
> at java.lang.Thread.run(Thread.java:744)
> Caused by: java.lang.Exception: Error running node security.Validate
> at org.apache.accumulo.test.randomwalk.Module.visit(Module.java:285)
> at org.apache.accumulo.test.randomwalk.Module.visit(Module.java:254)
> ... 8 more
> Caused by: org.apache.accumulo.core.client.AccumuloException: Unexpected
> exception!
> at
> org.apache.accumulo.test.randomwalk.security.Validate.validate(Validate.java:117)
> at
> org.apache.accumulo.test.randomwalk.security.Validate.visit(Validate.java:37)
> at org.apache.accumulo.test.randomwalk.Module.visit(Module.java:254)
> ... 9 more
> Caused by: ThriftSecurityException(user:table_hostname_domain,
> code:USER_DOESNT_EXIST)
> at
> org.apache.accumulo.server.security.SecurityOperation.targetUserExists(SecurityOperation.java:277)
> at
> org.apache.accumulo.server.security.SecurityOperation.getUserAuthorizations(SecurityOperation.java:197)
> at
> org.apache.accumulo.server.security.SecurityOperation.getUserAuthorizations(SecurityOperation.java:214)
> at
> org.apache.accumulo.test.randomwalk.security.Validate.validate(Validate.java:108)
> ... 11 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
