[ 
https://issues.apache.org/jira/browse/ACCUMULO-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909385#comment-13909385
 ] 

Vincent Russell commented on ACCUMULO-1376:
-------------------------------------------

Thanks for the comments Josh.  

1) The patch is based on 1.6; however I imagine it can go back further.    

2) I will take a look at the codestyle guidelines and make sure my IDE conforms 
to that.

3)  I saw the ShellTest and didn't see a good way to add a test there, but did 
not see ShellServerTest/ShellServerIT so I didn't attempt to write a test 
there.   I will write a test in ShellServerIT for 1.6, unless you think I 
should try to patch 1.5.  

Also,

Is there documentation on the process to follow for submitting patches?  I kind 
of just figured this out and I'm not sure if I did it properly.

Thanks again Josh



> Shell should verify before dropping user
> ----------------------------------------
>
>                 Key: ACCUMULO-1376
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1376
>             Project: Accumulo
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 1.5.0
>            Reporter: John Vines
>            Assignee: Billie Rinaldi
>            Priority: Trivial
>              Labels: patch
>         Attachments: ACCUMULO-1376.patch
>
>
> The shell checks before you drop a table. It should probably do the same for 
> users.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to