[ 
https://issues.apache.org/jira/browse/ACCUMULO-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910432#comment-13910432
 ] 

Bill Havanki commented on ACCUMULO-2345:
----------------------------------------

The patch introduces Mockito, while we already have Easymock available as a 
dependency. Could you convert the unit test to Easymock for consistency?

I'd be fine if this led to a discussion about which framework the project 
should use, as long as we settle on just one.

> Improve ConstraintChecker.check
> -------------------------------
>
>                 Key: ACCUMULO-2345
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2345
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: tserver
>    Affects Versions: 1.7.0
>            Reporter: Vikram Srivastava
>            Assignee: Vikram Srivastava
>            Priority: Trivial
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-2345.v1.patch.txt, ACCUMULO-2345.v2.patch.txt
>
>
> The if-else condition inside {{for}} loop can be merged with try-catch since 
> {{throwable}} is not null only if code goes inside the catch section.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to