[ 
https://issues.apache.org/jira/browse/ACCUMULO-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948466#comment-13948466
 ] 

Sean Busbey commented on ACCUMULO-1945:
---------------------------------------

You should squash them locally into a single commit and then export that patch 
for attaching here.

[see our git workflow suggestion for 
contributors|http://accumulo.apache.org/git.html#contributors]

It's not formalized in that guide, but I encourage people to follow the naming 
guidelines similar to Hive and Avro:

{noformat}
  ACCUMULO-XXXX.Y[-BRANCH].patch.txt
{noformat}

* ACCUMULO relevant jira tracker
* XXXX             jira number
* Y                    one up counter of revisions
* BRANCH       optional branch patch applies to

The .patch.txt bit is so that we know it's a patch (as opposed to a design 
document or something) and so that it will easily render as text in a browser.

For Accumulo the BRANCH portion is assumed to be the earliest fix version if it 
isn't present. It's usually only necessary to include one when you have to give 
a follow on patch for one of the newer dev branches if the merge goes poorly.

Generally we attempt to leave old patches in place so people can easily follow 
how things progressed. Then only the latest one is used (or the latest for a 
particular branch).

Following the above, I'd prefer if you could attach a single patch for all the 
changes needed in this ticket with the name ACCUMULO-1945.3.patch.txt

> bin/accumulo help should print usage
> ------------------------------------
>
>                 Key: ACCUMULO-1945
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1945
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: start
>            Reporter: John Vines
>            Assignee: Andrew George Wells
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 1.4.5
>
>         Attachments: ACCUMULO-1945-1.patch.txt, ACCUMULO-1945-2.patch.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to