[ 
https://issues.apache.org/jira/browse/ACCUMULO-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958640#comment-13958640
 ] 

Sean Busbey commented on ACCUMULO-2619:
---------------------------------------

I'd like feedback on target version for fixing this. Presuming any of the 
clone() methods in the public API can be removed, I'd kind of like to find time 
to deprecate them for the 1.6.0 release so that they can be removed in the next 
major version.

> Review use of Cloneable
> -----------------------
>
>                 Key: ACCUMULO-2619
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2619
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Sean Busbey
>            Priority: Minor
>
> We have a few places that claim cloneable, including in the public API. Go 
> through and bring them in line with Effective  Java.
> Note that this means where possible we should favor a copy constructor to 
> using the clone method, since it is fundamentally broken.
> Where we must have it we need to make sure we obey all the rules.
> # return the type of the class implementing Cloneable
> # do not throw CloneNotSupportedException
> # make sure to return the result of super.clone() (unless the class is final)
> # any fields that are not safe to share between an object and its clone must 
> be deep copied after using super.clone().



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to