Bill Havanki created ACCUMULO-2759:
--------------------------------------
Summary: Suspicious extra work in MasterMetadataUtil.fixSplit()
Key: ACCUMULO-2759
URL: https://issues.apache.org/jira/browse/ACCUMULO-2759
Project: Accumulo
Issue Type: Improvement
Components: master
Reporter: Bill Havanki
Priority: Minor
PMD reports that four parameters are not used in the private
{{MasterMetadataUtil.fixSplit()}} method: tserver, initCompactID, time,
initFlushID. The public {{fixSplit()}} method, which calls the private one,
does work to retrieve the latter three from a map parameter and check and tweak
them, before passing them to the private method uselessly. In addition, the
tserver argument is just passed from the public method to the private one
untouched.
These extraneous parameters may simply be artifacts from the initial
development of this code, in which case they should be cleaned up so that
performance improves. It's also possible that the data should be used in the
code but erroneously isn't. There's no unit test laying out its expected
behavior.
(The class in question is not present before 1.6.0, but the code may be
somewhere else in prior versions. That should be checked too.)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
