[
https://issues.apache.org/jira/browse/ACCUMULO-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003631#comment-14003631
]
ASF GitHub Bot commented on ACCUMULO-2825:
------------------------------------------
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/7#issuecomment-43654266
Cool, I think that helps a lot. That's a neat approach to reduce the amount
of boilerplate between your "database" and application server. Thanks for
taking the time to write this up.
I'll let this open for a little while longer if anyone else has feedback
they want to give. If none comes out, I'll merge this in later tonight.
> WholeRowIterator should be extendable
> -------------------------------------
>
> Key: ACCUMULO-2825
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2825
> Project: Accumulo
> Issue Type: Improvement
> Components: client
> Affects Versions: 1.5.1, 1.6.0
> Reporter: Ryan Leary
> Assignee: Ryan Leary
> Priority: Minor
> Fix For: 1.6.1, 1.7.0
>
> Attachments: add_encode_row_iterator.patch
>
>
> It would be useful to be able to choose encodings other than what is
> implemented already in WholeRowIterator's encodeRow and decodeRow public
> static final methods.
> As an example, I wrote an iterator that reads in CQ/val pairs and
> automatically populates a protocol buffer. To do this, however, I essentially
> copy/pasted all of the WholeRowIterator source and changed the encode/decode
> methods.
> In the interest of not changing the WholeRowIterator API in any meaningful
> way (hopefully meaning this improvement could be added to 1.6.1), I have
> created a new abstract iterator: RowEncodingIterator, which WholeRowIterator
> now extends, implementing rowEncoder and rowDecoder.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
