[ 
https://issues.apache.org/jira/browse/ACCUMULO-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026519#comment-14026519
 ] 

Josh Elser commented on ACCUMULO-2511:
--------------------------------------

Because this is an incompatible API change, this needs to be done in {{master}} 
to ensure no API breakage occurs in already-released major versions (e.g. 
1.5.x, 1.6.y)

> Value allows equals(byte[])
> ---------------------------
>
>                 Key: ACCUMULO-2511
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2511
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Sean Busbey
>              Labels: findbugs, incompatible, newbie
>
> Right now the equals(Object) method for Value is
> {noformat}
>  @Override
>   public boolean equals(Object right_obj) {
>     if (right_obj instanceof byte[]) {
>       return compareTo((byte[]) right_obj) == 0;
>     }
>     if (right_obj instanceof Value) {
>       return compareTo(right_obj) == 0;
>     }
>     return false;
>   }
> {noformat}
> It's in a section that says it was copied from BytesWritable.
> If we're not using this optimization anywhere, I'd rather remove it since it 
> is non-intuitive.
> If we are using it, I'd prefer we move it into something other than the 
> general equals



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to