[ 
https://issues.apache.org/jira/browse/ACCUMULO-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213984#comment-14213984
 ] 

Christopher Tubbs commented on ACCUMULO-3338:
---------------------------------------------

bq. A "close" comment followed immediately with a new "open" adds no value 
whatsoever in my opinion. That is why I removed the "close" comments. ... I'm 
not going to feel bad for missing that, but thank you for bringing it to my 
attention.

Makes sense, and you shouldn't feel bad. We just need to be careful to cross 
check any changes with the templates with the thing that uses them. :)

bq. I imagine you didn't even realize, but bootstrap_config.sh was already 
broken in generating hadoop1 configs.

I did not! Thanks for the fix.

bq. Unless you can present some case where there are other jars that happen to 
also match these regexs, there is no risk.

That's not quite true. The risk of extra paths in the classpath is that the 
extra path might be writable by other users, depending on the platform and 
circumstance, and could conceivably contain undesirable classes at some future 
point, regardless of whether they currently contain any. In other words, the 
risk is not "known bad jars present", it's "not known to be free of bad jars". 
(by "bad jars", I mean anything incompatible, malicious, or unintentional)

bq. Again, these are example configurations which really aren't meant for 
production use. Users shouldn't be using these configs outside of testing and 
have custom configuration files which have a minimal set of classpath entries 
for their specific system.

+1, as long as we continue this consistent message and treat these examples as 
examples, I see no issue.

bq. Christopher Tubbs please start a thread on the mailing list if you want to 
continue the discussion.

No need. I was just curious what those paths were intended to support (since it 
wasn't described in the issue or the commit log). As an example, it seems 
reasonable to support another major distribution out-of-the box. If the example 
classpath starts getting out of control, we can revisit. With the limited set 
there is now, I cannot complain.

> Update example classpath configuration
> --------------------------------------
>
>                 Key: ACCUMULO-3338
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3338
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: docs
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Trivial
>             Fix For: 1.6.2, 1.7.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Make sure the example configuration general.classpaths contain some extra 
> paths for HDFS jars which make them more likely to generally work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to