[
https://issues.apache.org/jira/browse/ACCUMULO-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275570#comment-14275570
]
Josh Elser commented on ACCUMULO-3467:
--------------------------------------
Overall, it looks good. A few minor things that could be improved:
{code}
+ if (System.currentTimeMillis() - t1 < 2000)
+ Assert.fail();
{code}
It would be nice to include an error message in the {{fail()}}.
{code}
- if (iterators.size() > 0 || compactionStrategy != null) {
+ if (iterators.size() > 0 || !compactionStrategy.equals(new
CompactionConfig().getCompactionStrategy())) {
{code}
You could get the "default" compaction strategy once (make a static final
instance in CompactionConfig) instead of recreating a CompactionConfig and
EverythingCompactionStrategy each time this is called.
{code}
+ compactionStrategy = new CompactionConfig().getCompactionStrategy();
{code}
Could re-use the default CompactionStrategy instance here, too.
{code}
- "Another compaction with iterators is running");
+ "Another compaction with iterators and/or a compaction
strategy is running");
{code}
If you're already changing this message, would it be worthwhile to mention why
this is disallowed? Do we have a documentation elsewhere (user manual)?
> MetadataIT.testFlushAndCompact occasionally fails
> -------------------------------------------------
>
> Key: ACCUMULO-3467
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3467
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Reporter: Josh Elser
> Assignee: Keith Turner
> Fix For: 1.7.0
>
> Attachments: ACCUMULO-3467-1.patch
>
>
> I'm seeing this test occasionally fail for me on master (haven't checked
> other branches).
> {noformat}
> Running org.apache.accumulo.test.functional.MetadataIT
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 10.598 sec
> <<< FAILURE! - in org.apache.accumulo.test.functional.MetadataIT
> testFlushAndCompact(org.apache.accumulo.test.functional.MetadataIT) Time
> elapsed: 10.413 sec <<< ERROR!
> org.apache.accumulo.core.client.AccumuloException: Another compaction with
> iterators is running
> at
> org.apache.accumulo.core.master.thrift.FateService$waitForFateOperation_result$waitForFateOperation_resultStandardScheme.read(FateService.java:4243)
> at
> org.apache.accumulo.core.master.thrift.FateService$waitForFateOperation_result$waitForFateOperation_resultStandardScheme.read(FateService.java:4212)
> at
> org.apache.accumulo.core.master.thrift.FateService$waitForFateOperation_result.read(FateService.java:4146)
> at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:78)
> at
> org.apache.accumulo.core.master.thrift.FateService$Client.recv_waitForFateOperation(FateService.java:174)
> at
> org.apache.accumulo.core.master.thrift.FateService$Client.waitForFateOperation(FateService.java:159)
> at
> org.apache.accumulo.core.client.impl.TableOperationsImpl.waitForFateOperation(TableOperationsImpl.java:280)
> at
> org.apache.accumulo.core.client.impl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:322)
> at
> org.apache.accumulo.core.client.impl.TableOperationsImpl.compact(TableOperationsImpl.java:824)
> at
> org.apache.accumulo.core.client.impl.TableOperationsImpl.compact(TableOperationsImpl.java:802)
> at
> org.apache.accumulo.core.client.impl.TableOperationsImpl.compact(TableOperationsImpl.java:796)
> at
> org.apache.accumulo.test.functional.MetadataIT.testFlushAndCompact(MetadataIT.java:79)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
