Christopher Tubbs created ACCUMULO-3519:
-------------------------------------------

             Summary: Unused AccumuloSecurityException class
                 Key: ACCUMULO-3519
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3519
             Project: Accumulo
          Issue Type: Sub-task
            Reporter: Christopher Tubbs


AccumuloSecurityException has a public constructor which is completely unused. 
I don't know if we should consider constructors of exceptions "public API", but 
they are defined as such in the README, so a strict interpretation is that they 
are.

The unused constructor in question is:
{code}public AccumuloSecurityException(final String user, final 
SecurityErrorCode errorcode, final String tableInfo) { ... }{code}

This class also uses thrift objects in its constructors, which we don't 
consider public API, so either we should also consider constructors of 
exceptions to be *not* public API (in which case, we can just delete the unused 
constructor), or we should consider the use of thrift objects bugs.

If these constructors are public API, they should have tests and we shouldn't 
have any unused (because they would minimally be referenced in tests).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to