[
https://issues.apache.org/jira/browse/ACCUMULO-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362500#comment-14362500
]
Josh Elser commented on ACCUMULO-3651:
--------------------------------------
core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java
has a bunch of changed imports which can just be reverted since it's
thrift-generated.
Otherwise, LGTM. Thanks for the obviously pedantic changeset.
> Replace log4j dependencies with slf4j where setLevel is not used.
> -----------------------------------------------------------------
>
> Key: ACCUMULO-3651
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3651
> Project: Accumulo
> Issue Type: Sub-task
> Components: build
> Affects Versions: 1.7.0
> Reporter: Ed Coleman
> Assignee: Ed Coleman
> Labels: patch
> Fix For: 1.7.0
>
> Attachments: ACCUMULO-3651.2.patch, ACCUMULO-3651.patch
>
>
> Because of the issues originally encountered where setLevel is used, I'm
> going to break the task into a few sub-tasks that can be accomplished in
> stages.
> This is the first sub-task and will include converting to slf4j where
> setLevel is not used (that will be handled separately, after more discussion)
> nor where dom manipulation is used (tests if memory serves.)
> This sub-task should allow us to move forward while deferring the harder
> situations for later (and in other sub-tasks.)
> The work on this task will include some modification to log statements where
> exceptions are thrown without a message (message is required by slf4j) This
> sub-task will not include conversion to use {} parameter formatting
> optimization to avoid string concatenation - that will be a follow on
> sub-task.
> My rational for multiple sub-tasks it to allow the changes to be evaluated in
> isolation so that if there are objections, the core issue of removing direct
> log4j dependencies can continue to move forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
