[
https://issues.apache.org/jira/browse/ACCUMULO-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Tubbs updated ACCUMULO-2131:
----------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Applied [~bthorman]'s patch. Thanks, Bob!
(Leaving second patch available here, for future reference, in case this issue
needs to be revisted and the behavior of the switchSource method needs to
change to match Keith's description above.)
> while statement used as if statement
> ------------------------------------
>
> Key: ACCUMULO-2131
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2131
> Project: Accumulo
> Issue Type: Bug
> Components: tserver
> Reporter: Eric Newton
> Assignee: Bob Thorman
> Priority: Trivial
> Labels: newbie
> Fix For: 1.7.0
>
> Attachments:
> 0001-ACCUMULO-2131-Ensure-source-is-re-checked-for-being-.patch,
> ACCUMULO-2131.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Going through PMD output, and this looks a little sketchy in
> SourceSwitchingIterator.java:
> {noformat}
> private boolean switchSource() throws IOException {
> while (!source.isCurrent()) {
> source = source.getNewDataSource();
> iter = source.iterator();
> if (iflag != null)
> ((InterruptibleIterator) iter).setInterruptFlag(iflag);
>
> return true;
> }
>
> return false;
> }
> {noformat}
> I'm wondering if that "while" should be "if"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
